fix: correctly apply file link attributes #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakimio
requested review from
MarsiBarsi,
waterplea,
nsbarsukov,
vladimirpotekhin and
mdlufy
and removed request for
a team
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
|
Visit the preview URL for this PR (updated for commit 41ad6c0): https://taiga-editor--pr1626-file-link-attribute-fix-demo-pixxratc.web.app (expires Wed, 18 Dec 2024 09:59:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c332df40371bee0fa68e2139313c6db411ab5f82 |
Playwright test results
Details
Failed testschromium › tests/anchors.spec.ts › Anchors › make anchor |
splincode
approved these changes
Dec 17, 2024
|
Anchor link test failure seems unrelated to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1624