Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): default options configuration for arrow #1251

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

GinMitch
Copy link
Contributor

@GinMitch GinMitch commented Jan 24, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Issue #133 is not fully implemented.

What is the new behavior?

Partial implementation of #133 for arrow component.

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 24, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

fixup for implementation, removed commented code
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #1251 (92f0617) into main (dfbc8a4) will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
+ Coverage   64.64%   64.67%   +0.02%     
==========================================
  Files         738      739       +1     
  Lines        8582     8588       +6     
  Branches     1727     1727              
==========================================
+ Hits         5548     5554       +6     
  Misses       2616     2616              
  Partials      418      418              
Flag Coverage Δ
addon-charts 72.06% <ø> (ø)
addon-doc 26.89% <ø> (ø)
addon-editor 46.05% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 82.33% <ø> (ø)
core 68.54% <100.00%> (ø)
kit 63.75% <85.71%> (+0.05%) ⬆️
summary 64.67% <87.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/arrow/arrow.module.ts 100.00% <ø> (ø)
projects/kit/components/arrow/arrow.component.ts 85.71% <50.00%> (+2.38%) ⬆️
projects/core/constants/version.ts 100.00% <100.00%> (ø)
projects/kit/components/arrow/arrow-options.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9963e...92f0617. Read the comment docs.

@waterplea
Copy link
Collaborator

waterplea commented Jan 25, 2022

Not sure what's wrong with the other screenshots but the last one looks worrying. The arrow is not rotated on open select 🤔 Just in case, merge main branch in your code, maybe it would fix other screenshots.

@GinMitch GinMitch marked this pull request as ready for review January 25, 2022 10:33
@waterplea waterplea merged commit 8b99faa into taiga-family:main Jan 25, 2022
@well-done-bot
Copy link

well-done-bot bot commented Jan 25, 2022

'Well done'

@GinMitch GinMitch deleted the feat/arrow-options branch February 2, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants