-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): default options configuration for arrow #1251
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
fixup for implementation, removed commented code
Codecov Report
@@ Coverage Diff @@
## main #1251 +/- ##
==========================================
+ Coverage 64.64% 64.67% +0.02%
==========================================
Files 738 739 +1
Lines 8582 8588 +6
Branches 1727 1727
==========================================
+ Hits 5548 5554 +6
Misses 2616 2616
Partials 418 418
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Not sure what's wrong with the other screenshots but the last one looks worrying. The arrow is not rotated on open select 🤔 Just in case, merge main branch in your code, maybe it would fix other screenshots. |
fix-up for implementation
fix-up for implementation
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue #133 is not fully implemented.
What is the new behavior?
Partial implementation of #133 for arrow component.
Does this PR introduce a breaking change?