Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix some minor typos in the home template #130

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

profanis
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

recommend you using our library
case. To use a custom sanitizer that properly supports
<code>SVG</code> provide the <code>TUI_SANITIZER</code> token. We
recommend you, using our library
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should rather be changed to ...you to use our...
Comma seems wrong here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was in between your suggestion and what I wrote. I will do the change :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waterplea I did the changes

Copy link
Collaborator

@MarsiBarsi MarsiBarsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🎉

@MarsiBarsi MarsiBarsi merged commit a4b3b3a into taiga-family:main Jan 22, 2021
fynnfeldpausch added a commit to mindsmash/taiga-ui that referenced this pull request Jan 23, 2021
* main: (53 commits)
  chore(core): fix version and its script
  chore(changelog): fix incorrect generated logs
  chore(release): 2.2.1
  chore(scripts): update sync-version with deps
  fix(highlight): change background color to selection (taiga-family#137)
  chore(core): update version
  chore(release.js): fix ammend comment to prevent changelog issues
  chore(changelog): fix incorrect comparison
  chore(release): 2.2.0
  refactor(all): remove unnecessary less variables (taiga-family#132)
  chore(kit): fix typing issue
  chore(kit): fix async issue
  chore(all): fix comments
  docs(demo): fix some minor typos in the home template (taiga-family#130)
  fix(cdk): `Media` fix stuttering in Safari (taiga-family#129)
  docs(demo): fix a type (taiga-family#128)
  feat(demo): add page for `Sidebar` directive (taiga-family#125)
  chore(kit): fix build error
  chore(i18n): fix use before declaration error
  chore(i18n): bump version after merge main
  ...

# Conflicts:
#	.github/workflows/build.yml
#	.github/workflows/lint.yml
#	.github/workflows/test.yml
#	projects/core/components/button/button.style.less
#	projects/core/components/data-list/option/option.style.less
#	projects/core/components/hints-host/hint-box/hint-box.style.less
#	projects/core/styles/mixins/textfield.less
#	projects/core/styles/theme/variables.less
#	projects/core/styles/variables/sizes.less
#	projects/demo/src/modules/markup/typography/typography.template.html
#	projects/kit/components/accordion/accordion-item/accordion-item.style.less
#	projects/kit/components/badge/badge.style.less
#	projects/kit/components/checkbox-block/checkbox-block.style.less
#	projects/kit/components/input-count/input-count.style.less
#	projects/kit/components/input-tag/input-tag.style.less
#	projects/kit/components/toggle/toggle.style.less
fynnfeldpausch added a commit to mindsmash/taiga-ui that referenced this pull request Jan 24, 2021
* main: (53 commits)
  chore(core): fix version and its script
  chore(changelog): fix incorrect generated logs
  chore(release): 2.2.1
  chore(scripts): update sync-version with deps
  fix(highlight): change background color to selection (taiga-family#137)
  chore(core): update version
  chore(release.js): fix ammend comment to prevent changelog issues
  chore(changelog): fix incorrect comparison
  chore(release): 2.2.0
  refactor(all): remove unnecessary less variables (taiga-family#132)
  chore(kit): fix typing issue
  chore(kit): fix async issue
  chore(all): fix comments
  docs(demo): fix some minor typos in the home template (taiga-family#130)
  fix(cdk): `Media` fix stuttering in Safari (taiga-family#129)
  docs(demo): fix a type (taiga-family#128)
  feat(demo): add page for `Sidebar` directive (taiga-family#125)
  chore(kit): fix build error
  chore(i18n): fix use before declaration error
  chore(i18n): bump version after merge main
  ...

# Conflicts:
#	.github/workflows/build.yml
#	.github/workflows/lint.yml
#	.github/workflows/test.yml
#	projects/core/components/button/button.style.less
#	projects/core/components/data-list/option/option.style.less
#	projects/core/components/hints-host/hint-box/hint-box.style.less
#	projects/core/styles/mixins/textfield.less
#	projects/core/styles/theme/variables.less
#	projects/core/styles/variables/sizes.less
#	projects/demo/src/modules/markup/typography/typography.template.html
#	projects/kit/components/accordion/accordion-item/accordion-item.style.less
#	projects/kit/components/badge/badge.style.less
#	projects/kit/components/checkbox-block/checkbox-block.style.less
#	projects/kit/components/input-count/input-count.style.less
#	projects/kit/components/input-tag/input-tag.style.less
#	projects/kit/components/toggle/toggle.style.less
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants