-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix some minor typos in the home template #130
Conversation
recommend you using our library | ||
case. To use a custom sanitizer that properly supports | ||
<code>SVG</code> provide the <code>TUI_SANITIZER</code> token. We | ||
recommend you, using our library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should rather be changed to ...you to use our...
Comma seems wrong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was in between your suggestion and what I wrote. I will do the change :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waterplea I did the changes
eb29d16
to
a2ba977
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 🎉
* main: (53 commits) chore(core): fix version and its script chore(changelog): fix incorrect generated logs chore(release): 2.2.1 chore(scripts): update sync-version with deps fix(highlight): change background color to selection (taiga-family#137) chore(core): update version chore(release.js): fix ammend comment to prevent changelog issues chore(changelog): fix incorrect comparison chore(release): 2.2.0 refactor(all): remove unnecessary less variables (taiga-family#132) chore(kit): fix typing issue chore(kit): fix async issue chore(all): fix comments docs(demo): fix some minor typos in the home template (taiga-family#130) fix(cdk): `Media` fix stuttering in Safari (taiga-family#129) docs(demo): fix a type (taiga-family#128) feat(demo): add page for `Sidebar` directive (taiga-family#125) chore(kit): fix build error chore(i18n): fix use before declaration error chore(i18n): bump version after merge main ... # Conflicts: # .github/workflows/build.yml # .github/workflows/lint.yml # .github/workflows/test.yml # projects/core/components/button/button.style.less # projects/core/components/data-list/option/option.style.less # projects/core/components/hints-host/hint-box/hint-box.style.less # projects/core/styles/mixins/textfield.less # projects/core/styles/theme/variables.less # projects/core/styles/variables/sizes.less # projects/demo/src/modules/markup/typography/typography.template.html # projects/kit/components/accordion/accordion-item/accordion-item.style.less # projects/kit/components/badge/badge.style.less # projects/kit/components/checkbox-block/checkbox-block.style.less # projects/kit/components/input-count/input-count.style.less # projects/kit/components/input-tag/input-tag.style.less # projects/kit/components/toggle/toggle.style.less
* main: (53 commits) chore(core): fix version and its script chore(changelog): fix incorrect generated logs chore(release): 2.2.1 chore(scripts): update sync-version with deps fix(highlight): change background color to selection (taiga-family#137) chore(core): update version chore(release.js): fix ammend comment to prevent changelog issues chore(changelog): fix incorrect comparison chore(release): 2.2.0 refactor(all): remove unnecessary less variables (taiga-family#132) chore(kit): fix typing issue chore(kit): fix async issue chore(all): fix comments docs(demo): fix some minor typos in the home template (taiga-family#130) fix(cdk): `Media` fix stuttering in Safari (taiga-family#129) docs(demo): fix a type (taiga-family#128) feat(demo): add page for `Sidebar` directive (taiga-family#125) chore(kit): fix build error chore(i18n): fix use before declaration error chore(i18n): bump version after merge main ... # Conflicts: # .github/workflows/build.yml # .github/workflows/lint.yml # .github/workflows/test.yml # projects/core/components/button/button.style.less # projects/core/components/data-list/option/option.style.less # projects/core/components/hints-host/hint-box/hint-box.style.less # projects/core/styles/mixins/textfield.less # projects/core/styles/theme/variables.less # projects/core/styles/variables/sizes.less # projects/demo/src/modules/markup/typography/typography.template.html # projects/kit/components/accordion/accordion-item/accordion-item.style.less # projects/kit/components/badge/badge.style.less # projects/kit/components/checkbox-block/checkbox-block.style.less # projects/kit/components/input-count/input-count.style.less # projects/kit/components/input-tag/input-tag.style.less # projects/kit/components/toggle/toggle.style.less
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information