Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core,kit): default options configuration helpers #1356

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

GinMitch
Copy link
Contributor

@GinMitch GinMitch commented Feb 9, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

What is the new behavior?

Follow-up changes for #133 introducing default options "factories".

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Feb 9, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #1356 (4dff5e9) into main (25a9c69) will increase coverage by 0.04%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   64.64%   64.68%   +0.04%     
==========================================
  Files         766      766              
  Lines        8739     8753      +14     
  Branches     1741     1741              
==========================================
+ Hits         5649     5662      +13     
- Misses       2673     2674       +1     
  Partials      417      417              
Flag Coverage Δ
addon-charts 72.10% <ø> (ø)
addon-doc 25.84% <ø> (ø)
addon-editor 46.05% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 82.33% <ø> (ø)
core 69.07% <100.00%> (+0.07%) ⬆️
kit 63.60% <93.54%> (+0.05%) ⬆️
summary 64.68% <94.87%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/radio/radio.component.ts 25.00% <0.00%> (ø)
projects/kit/components/arrow/arrow-options.ts 90.00% <75.00%> (-10.00%) ⬇️
projects/core/components/button/button-options.ts 100.00% <100.00%> (ø)
...rojects/core/components/button/button.component.ts 82.14% <100.00%> (ø)
...primitive-textfield/primitive-textfield-options.ts 100.00% <100.00%> (ø)
projects/core/directives/hint/hint-options.ts 100.00% <100.00%> (ø)
...core/directives/manual-hint/manual-hint-options.ts 100.00% <100.00%> (ø)
...re/directives/pointer-hint/pointer-hint-options.ts 100.00% <100.00%> (ø)
.../components/carousel/carousel-buttons.directive.ts 100.00% <100.00%> (ø)
...ects/kit/components/checkbox/checkbox.component.ts 46.66% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a9c69...4dff5e9. Read the comment docs.

@waterplea waterplea merged commit 2259182 into taiga-family:main Feb 11, 2022
@well-done-bot
Copy link

well-done-bot bot commented Feb 11, 2022

'Well done'

@GinMitch GinMitch deleted the feat/option-token-helpers branch February 11, 2022 09:25
vladimirpotekhin pushed a commit that referenced this pull request Feb 17, 2022
* feat(core,kit): default options configuration helpers

* feat(core,kit): default options configuration helpers

fixed arrow mode provider

* feat(core,kit): default options configuration helpers

fixes according to PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants