Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): DataList missing paddings inside Option (multiline text problem) #1820

Merged
merged 1 commit into from
May 30, 2022

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented May 26, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #1687

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@nsbarsukov nsbarsukov self-assigned this May 26, 2022
@lumberjack-bot
Copy link

lumberjack-bot bot commented May 26, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

Visit the preview URL for this PR (updated for commit a65f42a):

https://taiga-ui--pr1820-datalist-long-text-o-isywrvja.web.app

(expires Sat, 28 May 2022 07:36:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1820 (a65f42a) into main (19d7bce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1820   +/-   ##
=======================================
  Coverage   63.19%   63.19%           
=======================================
  Files         931      931           
  Lines       10064    10064           
  Branches     1946     1946           
=======================================
  Hits         6360     6360           
  Misses       3250     3250           
  Partials      454      454           
Flag Coverage Δ
addon-charts 74.42% <ø> (ø)
addon-doc 26.73% <ø> (ø)
addon-editor 45.87% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 79.59% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 68.77% <ø> (ø)
core 67.99% <ø> (ø)
kit 63.04% <ø> (ø)
summary 63.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19d7bce...a65f42a. Read the comment docs.

@nsbarsukov nsbarsukov force-pushed the datalist-long-text-option-bug branch from 2389b32 to a65f42a Compare May 27, 2022 07:30
@nsbarsukov nsbarsukov changed the title [WIP] fix(core): DataList missing paddings inside Option (multiline text problem) fix(core): DataList missing paddings inside Option (multiline text problem) May 27, 2022
@nsbarsukov nsbarsukov marked this pull request as ready for review May 27, 2022 08:42
@nsbarsukov
Copy link
Member Author

Failed screenshots – changed horizontal padding for s-size.
It is expected.

@nsbarsukov nsbarsukov merged commit e206921 into main May 30, 2022
@nsbarsukov nsbarsukov deleted the datalist-long-text-option-bug branch May 30, 2022 04:21
@well-done-bot
Copy link

well-done-bot bot commented May 30, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - missing padding between tuioption in tuidatalist if tuioption has long multiline text
3 participants