Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): new component Cell #5460

Merged
merged 8 commits into from
Oct 27, 2023
Merged

feat(experimental): new component Cell #5460

merged 8 commits into from
Oct 27, 2023

Conversation

nsbarsukov
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the new behavior?

Figma

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 22, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Sep 22, 2023

BundleMon

Files updated (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
201.45KB (+435B +0.21%) +10%
demo/browser/runtime.(hash).js
38.6KB (+199B +0.51%) +10%
demo/browser/main.(hash).js
338.68KB (+89B +0.03%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +723B +0.11%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.23MB (+12.22KB +0.54%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Visit the preview URL for this PR (updated for commit 9258715):

https://taiga-ui--pr5460-cell-cpe9q8vu.web.app

(expires Sat, 28 Oct 2023 08:45:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #5460 (9258715) into main (90425d4) will increase coverage by 0.00%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5460   +/-   ##
=======================================
  Coverage   72.32%   72.32%           
=======================================
  Files        1451     1451           
  Lines       15806    15807    +1     
  Branches     2224     2224           
=======================================
+ Hits        11432    11433    +1     
  Misses       4013     4013           
  Partials      361      361           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.53% <ø> (ø)
addon-mobile 61.25% <ø> (ø)
addon-table 60.63% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.71% <ø> (ø)
core 77.95% <ø> (ø)
kit 70.88% <100.00%> (+<0.01%) ⬆️
summary 72.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../components/data-list-wrapper/data-list-wrapper.ts 78.94% <100.00%> (+1.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nsbarsukov nsbarsukov changed the title feat(experimental): new component Cell [WIP] feat(experimental): new component Cell Oct 11, 2023
@nsbarsukov nsbarsukov changed the title [WIP] feat(experimental): new component Cell feat(experimental): new component Cell Oct 13, 2023
@vladimirpotekhin
Copy link
Member

something wrong with the s-size icon
https://taiga-ui--pr5460-cell-6chs8fss.web.app/experimental/cell/API?size=s

Снимок экрана 2023-10-16 в 14 40 06

@nsbarsukov
Copy link
Member Author

something wrong with the s-size icon https://taiga-ui--pr5460-cell-6chs8fss.web.app/experimental/cell/API?size=s

@vladimirpotekhin fixed

@splincode splincode merged commit 343f2e8 into main Oct 27, 2023
36 checks passed
@splincode splincode deleted the cell branch October 27, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants