Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Segmented add new component #6527

Merged
merged 1 commit into from
Jan 25, 2024
Merged

feat(experimental): Segmented add new component #6527

merged 1 commit into from
Jan 25, 2024

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

Copy link

lumberjack-bot bot commented Jan 23, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Visit the preview URL for this PR (updated for commit a172baa):

https://taiga-ui--pr6527-segmented-eycc8289.web.app

(expires Thu, 25 Jan 2024 12:55:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jan 23, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
388.63KB (+1.39KB +0.36%) +10%
demo/browser/runtime.(hash).js
34.06KB (+32B +0.09%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
214.63KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%
demo/browser/styles.(hash).css
1.06KB +10%

Total files change +1.42KB +0.22%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.18MB (+6.62KB +0.3%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c740d00) 69.51% compared to head (a172baa) 69.58%.
Report is 4 commits behind head on main.

Files Patch % Lines
.../addon-doc/components/example/example.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6527      +/-   ##
==========================================
+ Coverage   69.51%   69.58%   +0.06%     
==========================================
  Files        1156     1156              
  Lines       12595    12581      -14     
  Branches     1764     1763       -1     
==========================================
- Hits         8756     8755       -1     
+ Misses       3555     3542      -13     
  Partials      284      284              
Flag Coverage Δ
summary 69.58% <80.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode added the v4 4.0 candidate label Jan 25, 2024
@splincode splincode merged commit ae3bd31 into main Jan 25, 2024
27 checks passed
@splincode splincode deleted the segmented branch January 25, 2024 10:55
@hakimio
Copy link
Contributor

hakimio commented Feb 12, 2024

@waterplea is it possible to use segmented component in a reactive form as a radio input?

@waterplea
Copy link
Collaborator Author

@waterplea is it possible to use segmented component in a reactive form as a radio input?

Sure, just like you would use reactive forms with regular input type="radio"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants