feat(core)!: Loader has new algorithm to calculate stroke-width
#6550
Conversation
nsbarsukov
commented
Jan 25, 2024
nsbarsukov
commented
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
|
Visit the preview URL for this PR (updated for commit 8587587): https://taiga-ui--pr6550-loader-stroke-width-tlbce2dn.web.app (expires Sat, 27 Jan 2024 15:35:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
nsbarsukov
changed the title
Loader has new algorithm to calculate stroke-widthLoader has new algorithm to calculate stroke-width
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6550 +/- ##
=======================================
Coverage 69.39% 69.39%
=======================================
Files 1143 1143
Lines 12503 12503
Branches 1759 1759
=======================================
Hits 8677 8677
Misses 3542 3542
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +55B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
nsbarsukov
force-pushed
the
loader-stroke-width-v4
branch
from
a72e5b1
to
b1e9858
Compare
| @@ -54,6 +48,33 @@ | |||
| &._loading { | |||
| overflow: hidden; | |||
| } | |||
|
|
|||
| // Use native CSS max function instead LESS one | |||
| stroke-width: ~'max(calc(var(--t-size) / 12), 1.5px)'; | |||
There was a problem hiding this comment.
It is ok to use in v4.0
https://caniuse.com/css-math-functions
nsbarsukov
force-pushed
the
loader-stroke-width-v4
branch
from
f17e5ec
to
17364e3
Compare
nsbarsukov
changed the title
Loader has new algorithm to calculate stroke-widthLoader has new algorithm to calculate stroke-width
nsbarsukov
requested review from
waterplea,
MarsiBarsi and
vladimirpotekhin
as code owners
