feat(kit): allow dynamic changes to TUI_NUMBER_FORMAT #6856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirpotekhin
requested review from
waterplea,
MarsiBarsi,
nsbarsukov and
splincode
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
| @@ -149,7 +149,7 @@ describe('InputRange', () => { | |||
| }); | |||
|
|
|||
| it('does not rounds to nearest multiple of [quantum] until text field losses focus', () => { | |||
| inputPORight.sendText('8'); | |||
| inputPORight.sendText('8 лет'); | |||
There was a problem hiding this comment.
perhaps this is due to the removal of the initial calibration plugin from input-number, everything seems to be ok in the demo
splincode
approved these changes
Feb 22, 2024
|
Visit the preview URL for this PR (updated for commit ba421bf): https://taiga-ui--pr6856-format-dynamic-yhycjcta.web.app (expires Fri, 01 Mar 2024 10:12:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change -5B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
waterplea
reviewed
Feb 22, 2024
projects/core/directives/number-format/number-format.directive.ts
Outdated
Show resolved
Hide resolved
vladimirpotekhin
force-pushed
the
format-dynamic
branch
3 times, most recently
from
5bb8741
to
3d5dd3e
Compare
waterplea
reviewed
Feb 27, 2024
projects/demo/src/modules/directives/copy-processor/examples/1/index.ts
Outdated
Show resolved
Hide resolved
splincode
force-pushed
the
format-dynamic
branch
from
a2ba22b
to
1d97c3e
Compare
splincode
force-pushed
the
format-dynamic
branch
from
5858e07
to
ba421bf
Compare
waterplea
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2900, #2578
BREAKING CHANGES: remove
TUI_NUMBER_FORMAT_OBSERVABLEin favour ofTUI_NUMBER_FORMAT,tuiFormatNumberpipe requires async pipe now