Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): CalendarRange not update selectedActivePeriod, when value updates #8536

Closed
wants to merge 1 commit into from

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Aug 14, 2024

Closes #8527

After update value:

As Is:

as-is.mov

To Be:

to-be.mov

@mdlufy mdlufy added the v4 4.0 candidate label Aug 14, 2024
Copy link

lumberjack-bot bot commented Aug 14, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@mdlufy mdlufy changed the title fix(kit): CalendarRange not update selectedActivePeriod, when value updates [WIP] fix(kit): CalendarRange not update selectedActivePeriod, when value updates Aug 14, 2024
Copy link
Contributor

github-actions bot commented Aug 14, 2024

Visit the preview URL for this PR (updated for commit 1f6cbb4):

https://taiga-previews--pr8536-mdlufy-calendar-rang-jyv8oq4b.web.app

(expires Thu, 15 Aug 2024 17:10:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Aug 14, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
280.8KB (+65B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
216.25KB +10%
demo/browser/runtime.(hash).js
41.52KB +10%
demo/browser/styles.(hash).css
11.56KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +67B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.79MB (+71B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@mdlufy mdlufy force-pushed the mdlufy/calendar-range-checkbox branch from 3b82ab0 to 1f6cbb4 Compare August 14, 2024 17:06
@mdlufy mdlufy requested a review from splincode August 14, 2024 17:06
@mdlufy mdlufy changed the title [WIP] fix(kit): CalendarRange not update selectedActivePeriod, when value updates fix(kit): CalendarRange not update selectedActivePeriod, when value updates Aug 14, 2024
@mdlufy mdlufy marked this pull request as ready for review August 14, 2024 17:07
@waterplea
Copy link
Collaborator

Closing in favor of #8595

@waterplea waterplea closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 4.0 candidate
Development

Successfully merging this pull request may close these issues.

🐞 - TuiCalendarRange change does not update checkbox position
3 participants