Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): CalendarRange shows actual defaultViewedMonth #9009

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Sep 13, 2024

Close #8494

As Is:

as-is.mov

To Be:

to-be.mov

Copy link

lumberjack-bot bot commented Sep 13, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Visit the preview URL for this PR (updated for commit f9ba83a):

https://taiga-ui--pr9009-mdlufy-fix-qykz1xcr.web.app

(expires Fri, 25 Oct 2024 23:25:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Sep 13, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+397.66KB +10%
demo/browser/vendor.(hash).js
+214.53KB +10%
demo/browser/runtime.(hash).js
+42.04KB +10%
demo/browser/polyfills.(hash).js
+15.2KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +670.83KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.45MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@mdlufy mdlufy changed the title fix(kit): CalendarRange shows actual defaultViewedMonth [WIP] fix(kit): CalendarRange shows actual defaultViewedMonth Sep 16, 2024
@mdlufy mdlufy changed the title [WIP] fix(kit): CalendarRange shows actual defaultViewedMonth fix(kit): CalendarRange shows actual defaultViewedMonth Oct 8, 2024
@mdlufy mdlufy requested a review from waterplea October 8, 2024 14:15
@mdlufy mdlufy changed the title fix(kit): CalendarRange shows actual defaultViewedMonth [WIP] fix(kit): CalendarRange shows actual defaultViewedMonth Oct 8, 2024
@mdlufy mdlufy force-pushed the mdlufy/fix branch 2 times, most recently from 2be7297 to 4f79289 Compare October 8, 2024 16:39
@mdlufy mdlufy marked this pull request as draft October 15, 2024 11:07
Copy link
Collaborator Author

@mdlufy mdlufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP: need to fix case when value in right calendar selected - it's switched no to the next month

Copy link
Collaborator Author

@mdlufy mdlufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP: need to fix case when value in right calendar selected - it's switched no to the next month

@mdlufy mdlufy changed the title [WIP] fix(kit): CalendarRange shows actual defaultViewedMonth fix(kit): CalendarRange shows actual defaultViewedMonth Nov 1, 2024
@mdlufy mdlufy marked this pull request as ready for review November 1, 2024 16:21
@mdlufy
Copy link
Collaborator Author

mdlufy commented Nov 1, 2024

WIP: need to fix case when value in right calendar selected - it's switched no to the next month
Fixed

@mdlufy mdlufy merged commit 3446afd into v3.x Nov 1, 2024
32 of 33 checks passed
@mdlufy mdlufy deleted the mdlufy/fix branch November 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants