Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(addon-commerce): InputCardGroup fix for older Safari #9134

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix(addon-commerce): InputCardGroup fix for older Safari #9134

merged 2 commits into from
Sep 24, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Sep 23, 2024

Close #9105
Close #9072

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 23, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v3 label Sep 23, 2024
@mdlufy mdlufy changed the title fix(addon-commerce): InputCardGroup fix for older Safari [WIP] fix(addon-commerce): InputCardGroup fix for older Safari Sep 23, 2024
@mdlufy mdlufy marked this pull request as draft September 23, 2024 13:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit abea091):

https://taiga-ui--pr9134-mdlufy-input-card-gr-bvv8ast5.web.app

(expires Tue, 24 Sep 2024 15:54:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 23, 2024 •
edited
Loading

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +397.64KB +10%
✅ demo/browser/vendor.(hash).js
 +214.55KB +10%
✅ demo/browser/runtime.(hash).js
 +42KB +10%
✅ demo/browser/polyfills.(hash).js
 +15.22KB +10%
✅ demo/browser/styles.(hash).css
 +1.39KB +10%

Total files change +670.81KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +2.45MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@mdlufy mdlufy marked this pull request as ready for review September 23, 2024 16:21
@mdlufy mdlufy changed the title [WIP] fix(addon-commerce): InputCardGroup fix for older Safari fix(addon-commerce): InputCardGroup fix for older Safari Sep 23, 2024
@splincode splincode merged commit 009f5f9 into v3.x Sep 24, 2024
32 of 33 checks passed
@splincode splincode deleted the mdlufy/input-card-group-v3 branch September 24, 2024 07:12
@taiga-family-bot taiga-family-bot mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

Assignees

@mdlufy mdlufy

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdlufy @waterplea @splincode