Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(addon-commerce): simplify html-structure of ThumbnailCard #9612

Merged
merged 2 commits into from
Oct 25, 2024
Merged

refactor(addon-commerce): simplify html-structure of ThumbnailCard #9612

merged 2 commits into from
Oct 25, 2024

Conversation

nsbarsukov
Copy link
Member

No description provided.

@nsbarsukov nsbarsukov self-assigned this Oct 25, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 25, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0259cb1):

https://taiga-previews--pr9612-thumbnail-card-u3il0j7q.web.app

(expires Sat, 26 Oct 2024 11:43:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 25, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 297.67KB +10%
✅ demo/browser/vendor.(hash).js
 255.67KB +10%
✅ demo/browser/runtime.(hash).js
 43.27KB +10%
✅ demo/browser/styles.(hash).css
 19.61KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +1B 0%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.17MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@nsbarsukov nsbarsukov marked this pull request as ready for review October 25, 2024 11:07
@nsbarsukov nsbarsukov requested a review from a team as a code owner October 25, 2024 11:07
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team October 25, 2024 11:07
@nsbarsukov nsbarsukov merged commit 2be740a into main Oct 25, 2024
25 of 26 checks passed
@nsbarsukov nsbarsukov deleted the thumbnail-card branch October 25, 2024 12:03
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
@nsbarsukov @shiv9604
refactor(addon-commerce): simplify html-structure of ThumbnailCard (t…
60d1949 
…aiga-family#9612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@nsbarsukov nsbarsukov

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsbarsukov @waterplea @vladimirpotekhin