Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): do not hide scrollbars on desktop when dialog is open #9633

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix(core): do not hide scrollbars on desktop when dialog is open #9633

merged 1 commit into from
Nov 5, 2024

Conversation

vladimirpotekhin
Copy link
Member

Fixes #9619

@vladimirpotekhin vladimirpotekhin requested a review from a team as a code owner October 29, 2024 11:58
@vladimirpotekhin vladimirpotekhin requested review from MarsiBarsi, waterplea, nsbarsukov and mdlufy and removed request for a team October 29, 2024 11:58
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 29, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit f667a90):

https://taiga-previews--pr9633-fix-dialog-scroll-ga0s17y1.web.app

(expires Wed, 30 Oct 2024 12:02:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 29, 2024

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 298.41KB (-33B -0.01%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 255.67KB +10%
✅ demo/browser/runtime.(hash).js
 43.39KB +10%
✅ demo/browser/styles.(hash).css
 19.61KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change -33B -0.01%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.22MB (-33B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@vladimirpotekhin vladimirpotekhin merged commit 5075a74 into main Nov 5, 2024
28 checks passed
@vladimirpotekhin vladimirpotekhin deleted the fix-dialog-scroll branch November 5, 2024 07:35
@taiga-family-bot taiga-family-bot mentioned this pull request Nov 5, 2024
Merged
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
@vladimirpotekhin @shiv9604
fix(core): do not hide scrollbars on desktop when dialog is open (tai…
692e64e 
…ga-family#9633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlufy mdlufy mdlufy approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

Assignees

@vladimirpotekhin vladimirpotekhin

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - scrolling disappears after close dialog
3 participants
@vladimirpotekhin @splincode @mdlufy