Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): #9644 Added top position example for ActionBar #9654

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

40oleg
Copy link
Collaborator

@40oleg 40oleg commented Oct 31, 2024

Fixes #9644

This MR add example in the demo how to place ActionBar to the top on page
Discussed with @vladimirpotekhin and @waterplea
Example: https://taiga-ui.dev/components/actions-bar#top-position (URL will be available after merge)

image

@40oleg 40oleg requested a review from a team as a code owner October 31, 2024 20:54
@40oleg 40oleg requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team October 31, 2024 20:54
@40oleg 40oleg self-assigned this Oct 31, 2024
Copy link

lumberjack-bot bot commented Oct 31, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Visit the preview URL for this PR (updated for commit 0ddc6d0):

https://taiga-previews--pr9654-feature-action-bar-p-16209xxa.web.app

(expires Fri, 08 Nov 2024 08:02:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 31, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
43.52KB (+62B +0.14%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
299KB +10%
demo/browser/vendor.(hash).js
260.04KB +10%
demo/browser/styles.(hash).css
19.6KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +62B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.25MB (+7.77KB +0.1%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@40oleg
Copy link
Collaborator Author

40oleg commented Nov 7, 2024

Failed tests ❌

Before (main) ← Diff → After (local)

tests-addon-doc-navigation-bbc63-getting-started-light-mode--chromium/01-tui-doc-navigation-light-mode.diff.png

tests-addon-doc-navigation-fa9c7--getting-started-dark-mode--chromium/02-tui-doc-navigation-dark-mode.diff.png

tests-demo-demo.pw-Demo-components-carousel-chromium/components-carousel/3.diff.png

(updated for commit 0ddc6d0)

I suppose it is problem of all PRs?

@vladimirpotekhin vladimirpotekhin merged commit 837f429 into main Nov 7, 2024
26 of 27 checks passed
@vladimirpotekhin vladimirpotekhin deleted the feature/action-bar-position branch November 7, 2024 10:48
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
…Bar` (taiga-family#9654)

Co-authored-by: 40oleg <oleg.merkulov701@gmail.com>
Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Add example of top position for ActionBar in demo
4 participants