Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-mobile): TuiElasticStickyService teardown observable zone fix #9657

Merged

Conversation

nezar-khamidekh
Copy link
Contributor

No description provided.

@nezar-khamidekh nezar-khamidekh requested a review from a team as a code owner November 1, 2024 09:12
@nezar-khamidekh nezar-khamidekh requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team November 1, 2024 09:12
Copy link

lumberjack-bot bot commented Nov 1, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.19%. Comparing base (4a26b1a) to head (20904c7).
Report is 577 commits behind head on main.

Files with missing lines Patch % Lines
...irectives/elastic-sticky/elastic-sticky.service.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9657      +/-   ##
==========================================
- Coverage   75.68%   75.19%   -0.49%     
==========================================
  Files        1216     1246      +30     
  Lines       19068    19560     +492     
  Branches     2091     2130      +39     
==========================================
+ Hits        14432    14709     +277     
- Misses       4592     4805     +213     
- Partials       44       46       +2     
Flag Coverage Δ
summary 75.19% <88.88%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Nov 1, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
298.65KB +10%
demo/browser/vendor.(hash).js
259.74KB +10%
demo/browser/runtime.(hash).js
43.48KB +10%
demo/browser/styles.(hash).css
19.61KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -1B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.24MB (+18B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nezar-khamidekh nezar-khamidekh changed the title ElasticSticky fix demo fix[addon-mobile] ElasticSticky demo Nov 1, 2024
@nezar-khamidekh nezar-khamidekh changed the title fix[addon-mobile] ElasticSticky demo fix[addon-mobile] TuiElasticStickyService teardown observable zone fix Nov 1, 2024
@nezar-khamidekh nezar-khamidekh changed the title fix[addon-mobile] TuiElasticStickyService teardown observable zone fix fix(addon-mobile): TuiElasticStickyService teardown observable zone fix Nov 1, 2024
@waterplea waterplea merged commit 5908330 into taiga-family:main Nov 5, 2024
26 checks passed
@nezar-khamidekh nezar-khamidekh deleted the fix/elastic-sticky-demo branch November 5, 2024 10:10
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants