Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add readable media aliases #9696

Merged
merged 1 commit into from
Nov 6, 2024
Merged

feat(core): add readable media aliases #9696

merged 1 commit into from
Nov 6, 2024

Conversation

splincode
Copy link
Member

No description provided.

@splincode splincode requested a review from a team as a code owner November 5, 2024 19:35
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team November 5, 2024 19:35
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 5, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit c1874f4):

https://taiga-previews--pr9696-splincode-feat-8568trdq.web.app

(expires Thu, 07 Nov 2024 14:14:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 5, 2024 •
edited
Loading

BundleMon

Files updated (2)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 299KB (+66B +0.02%) +10%
✅ demo/browser/styles.(hash).css
 19.6KB (+16B +0.08%) +10%
Unchanged files (3)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 260.04KB +10%
✅ demo/browser/runtime.(hash).js
 43.46KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +83B +0.01%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.24MB (+108B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

waterplea
waterplea approved these changes Nov 6, 2024
View reviewed changes
projects/core/styles/variables/media.less Outdated Show resolved Hide resolved
projects/core/styles/variables/media.scss Outdated Show resolved Hide resolved
projects/core/styles/variables/media.less Show resolved Hide resolved
@splincode splincode force-pushed the splincode/feat branch 2 times, most recently from 0ac775b to 05e24bb Compare November 6, 2024 10:03
@splincode splincode force-pushed the splincode/feat branch 2 times, most recently from 3bfff2f to 5c3bc6f Compare November 6, 2024 14:06
@splincode splincode enabled auto-merge (squash) November 6, 2024 14:23
@splincode splincode merged commit 41d89b3 into main Nov 6, 2024
24 of 25 checks passed
@splincode splincode deleted the splincode/feat branch November 6, 2024 14:30
@taiga-family-bot taiga-family-bot mentioned this pull request Nov 13, 2024
Merged
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
@splincode @shiv9604
feat(core): add readable media aliases (taiga-family#9696)
3239faf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@splincode splincode

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splincode @waterplea @vladimirpotekhin