Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): transform breaks fixed position in tiles #9905

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

splincode
Copy link
Member

Fixes #5619

New behaviour

Screen.Recording.2024-12-04.at.12.16.52.PM.mov

@splincode splincode requested a review from a team as a code owner December 4, 2024 09:18
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 4, 2024 09:18
Copy link

lumberjack-bot bot commented Dec 4, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Visit the preview URL for this PR (updated for commit cf6d2b6):

https://taiga-previews-demo--pr9905-splincode-fix-issues-5619-kt7kh2o3.web.app

(expires Thu, 05 Dec 2024 09:36:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@splincode splincode force-pushed the splincode/fix/issues/5619 branch from f5a0daf to f10344d Compare December 4, 2024 09:25
@splincode splincode force-pushed the splincode/fix/issues/5619 branch from 3d1d378 to cf6d2b6 Compare December 4, 2024 09:35
Copy link

bundlemon bot commented Dec 4, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
43.84KB (+59B +0.13%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
303.79KB +10%
demo/browser/vendor.(hash).js
259.99KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +55B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.33MB (+10.11KB +0.14%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Playwright test results

failed  1 failed
passed  974 passed

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  9 minutes, 4 seconds
commit  cf6d2b6

Failed tests

chromium › tests/demo/demo.pw.spec.ts › Demo › /components/tree

@splincode splincode merged commit 369d9a4 into main Dec 5, 2024
27 of 28 checks passed
@splincode splincode deleted the splincode/fix/issues/5619 branch December 5, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Tile drag position is wrong
3 participants