Skip to content

Commit

Permalink
Temporarily ignore version-range test on windows
Browse files Browse the repository at this point in the history 
rust-lang/rustup#3036
  • Loading branch information
@taiki-e
taiki-e committed Jul 22, 2022
1 parent 1e7fe62 commit e260052
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/test.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1298,6 +1298,7 @@ fn default_feature_behavior() {
.stdout_not_contains("has default feature!");
}

#[cfg_attr(windows, ignore)] // rustup bug: https://github.com/rust-lang/rustup/issues/3036
#[test]
fn version_range() {
cargo_hack(["check", "--version-range", "1.58..1.59"]).assert_success("real").stderr_contains(
Expand Down Expand Up @@ -1335,6 +1336,7 @@ fn version_range() {
}
}

#[cfg_attr(windows, ignore)] // rustup bug: https://github.com/rust-lang/rustup/issues/3036
#[test]
fn version_range_failure() {
// zero step
Expand Down

2 comments on commit e260052

@CAD97
Copy link

@CAD97 CAD97 commented on e260052 Jul 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ran into this while diagnosing my own fallout from the rustup issue)

Using rustup run toolchain cargo instead of cargo +toolchain may be more resilient, and worked in cargo-expand to fix the fallout.

That said, hack --version-range seems to be working fine on my Windows machine... the path issue is quite odd that it breaks some cases but not either, it seems.

rustup 1.25.1 (bb60b1e89 2022-07-12)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.62.1 (e092d0b6b 2022-07-16)`
cargo-hack 0.5.15

@taiki-e
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CAD97 Thanks! I will try the workaround you suggested.

That said, hack --version-range seems to be working fine on my Windows machine... the path issue is quite odd that it breaks some cases but not either, it seems.

Interesting. I ran into this problem on cargo-hack CI, so I wonder if it is related to how the toolchain was installed (maybe did we use a problematic rustup or not)?

Please sign in to comment.