Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add --all-features to combinations if it is already covered by another combination #141

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Dec 29, 2021

This fixes an issue where --feature-powerset and --each-feature add --all-features as one of the combinations, even if it is already covered by another combination. (The initial work on this fix was included in #140.)

Hopefully, the new behavior should be explained almost exactly in the long help message.

--each-feature
Perform for each feature of the package.
This also includes runs with just --no-default-features flag, and default features.
When this flag is not used together with --exclude-features (--skip) and
--include-features and there are multiple features, this also includes runs with just
--all-features flag.

--feature-powerset
Perform for the feature powerset of the package.
This also includes runs with just --no-default-features flag, and default features.
When this flag is used together with --depth or namespaced features (-Z
namespaced-features) and not used together with --exclude-features (--skip) and
--include-features and there are multiple features, this also includes runs with just
--all-features flag.

Follow-up: #42

@taiki-e
Copy link
Owner Author

taiki-e commented Dec 29, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 29, 2021

Build succeeded:

@bors bors bot merged commit 7260fc3 into main Dec 29, 2021
@bors bors bot deleted the all-features branch December 29, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant