Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --optional-deps flag #34

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Add --optional-deps flag #34

merged 1 commit into from
Apr 23, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Apr 23, 2020 

--optional-deps             Use optional dependencies as features,
                            this flag can only be used with either
                            `--each-feature` or `--feature-powerset`

Closes #28

@taiki-e

This comment has been minimized.

Sign in to view
bors bot added a commit that referenced this pull request Apr 23, 2020
@bors @taiki-e
Merge #34
8a53798 
34: Add --optional-deps flag r=taiki-e a=taiki-e

```txt
--optional-deps             Use optional dependencies as features,
                            this flag can only be used with either
                            `--each-feature` or `--feature-powerset`
```

Closes #28


Co-authored-by: Taiki Endo <te316e89@gmail.com>
@bors

This comment has been minimized.

Sign in to view
@taiki-e

This comment has been minimized.

Sign in to view
@taiki-e

This comment has been minimized.

Sign in to view
bors bot added a commit that referenced this pull request Apr 23, 2020
@bors @taiki-e
Merge #34
2d807e1 
34: Add --optional-deps flag r=taiki-e a=taiki-e

```txt
--optional-deps             Use optional dependencies as features,
                            this flag can only be used with either
                            `--each-feature` or `--feature-powerset`
```

Closes #28


Co-authored-by: Taiki Endo <te316e89@gmail.com>
@bors

This comment has been minimized.

Sign in to view
@taiki-e
Copy link
Owner Author

taiki-e commented Apr 23, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 23, 2020

Build succeeded:

@bors bors bot merged commit d08fe29 into master Apr 23, 2020
@bors bors bot deleted the optional-deps branch April 23, 2020 23:10
@taiki-e taiki-e mentioned this pull request Apr 24, 2020
Closed
@taiki-e taiki-e added A-features Area: features (--feature-powerset, --each-feature, etc.) C-enhancement Category: A new feature or an improvement for an existing one labels Oct 10, 2020
@taiki-e taiki-e removed the C-enhancement Category: A new feature or an improvement for an existing one label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request: some sort of argument to add "optional" deps as features
1 participant
@taiki-e