Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --target-dir in favor of CARGO_TARGET_DIR #112

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Use --target-dir in favor of CARGO_TARGET_DIR #112

merged 1 commit into from
Dec 22, 2021

Conversation

smoelius
Copy link
Contributor

Sorry it has taken me to long to get to this.

Please note that I also adjusted clean_args to set --manifest-path, as this seemed like the desired behavior.

Closes #100

@taiki-e
Copy link
Owner

taiki-e commented Dec 22, 2021

Thanks! This looks good to me. (CI is currently broken, so I will merge this after fixing that.)

this seemed like the desired behavior.

I agree with it is the desired behavior.

@taiki-e taiki-e mentioned this pull request Dec 22, 2021
Merged
@taiki-e
Copy link
Owner

taiki-e commented Dec 22, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 22, 2021

Build succeeded:

@bors bors bot merged commit a7cf5cd into taiki-e:main Dec 22, 2021
@taiki-e
Copy link
Owner

taiki-e commented Jan 6, 2022

Published in 0.1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CARGO_TARGET_DIR -> --target-dir?
2 participants
@smoelius @taiki-e