Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make object paths relative where possible. #126

Merged
merged 2 commits into from
Jan 16, 2022

Conversation

aganders3
Copy link
Contributor

Fixes #124 (well, alleviates it in some circumstance).

Thanks for the suggestion. This seems to just work so I think the part of the docs I was confused about is not related to relative paths of the CLI inputs.

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you solve clippy warning?

@aganders3
Copy link
Contributor Author

Oops, fixed. Thanks for the quick review!

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 16, 2022

Build succeeded:

@bors bors bot merged commit 3c4d67e into taiki-e:main Jan 16, 2022
@aganders3 aganders3 deleted the relative-object-paths branch January 16, 2022 13:27
@taiki-e
Copy link
Owner

taiki-e commented Jan 21, 2022

Published in 0.1.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating coverage report fails on Windows with too many objects
2 participants