Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to set the exit code based on coverage percentage #139

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

vmiklos
Copy link
Contributor

@vmiklos vmiklos commented Feb 24, 2022

Typing is dynamic in get_lines_percent() for now, as test data uses a
mix of ints and floats for percentages, see:

git grep percent tests/fixtures/

Fixes #137.

@vmiklos
Copy link
Contributor Author

vmiklos commented Feb 24, 2022

failed to get 200 response from [https://crates.io/api/v1/crates/easy-ext/1.0.0/download,](https://crates.io/api/v1/crates/easy-ext/1.0.0/download%60,) got 502

I guess we should try that again a bit later. :-)

Typing is dynamic in get_lines_percent() for now, as test data uses a
mix of ints and floats for percentages, see:

	git grep percent tests/fixtures/

Fixes taiki-e#137.
@vmiklos
Copy link
Contributor Author

vmiklos commented Feb 25, 2022

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vmiklos!

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 1, 2022

Build succeeded:

@bors bors bot merged commit 47db9ab into taiki-e:main Mar 1, 2022
@vmiklos vmiklos deleted the fail-under-lines branch March 1, 2022 12:45
@taiki-e
Copy link
Owner

taiki-e commented Mar 1, 2022

Published in 0.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit code based on coverage percentage
2 participants