Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --remap-path-prefix optional #141

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Make --remap-path-prefix optional #141

merged 1 commit into from
Apr 8, 2022

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Feb 25, 2022 •
edited
Loading

Fixes #140

cc #122

@taiki-e taiki-e mentioned this pull request Feb 25, 2022
Closed
@taiki-e taiki-e force-pushed the disable-remap-path-prefix branch from 54c35a9 to 20d5da7 Compare March 1, 2022 13:25
@ruifengx ruifengx mentioned this pull request Mar 2, 2022
Merged
ruifengx added a commit to ruifengx/rowantlr that referenced this pull request Mar 2, 2022
@ruifengx
try adopting the fix taiki-e/cargo-llvm-cov#141
fb97d37
@taiki-e taiki-e mentioned this pull request Mar 8, 2022
Open
@taiki-e
Copy link
Owner Author

taiki-e commented Mar 8, 2022 •
edited
Loading

Without this patch, coverage would obviously break in some cases, so for now we tend to merge this in a way that makes the --remap-path-prefix optional and release it as 0.3.

@taiki-e taiki-e force-pushed the disable-remap-path-prefix branch from 20d5da7 to 9c2029b Compare April 8, 2022 05:19
@taiki-e taiki-e changed the title Disable --remap-path-prefix Make --remap-path-prefix optional Apr 8, 2022
@taiki-e taiki-e marked this pull request as ready for review April 8, 2022 05:19
@taiki-e
Copy link
Owner Author

taiki-e commented Apr 8, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 8, 2022

Build succeeded:

@bors bors bot merged commit b4198cb into main Apr 8, 2022
@bors bors bot deleted the disable-remap-path-prefix branch April 8, 2022 05:33
@taiki-e taiki-e restored the disable-remap-path-prefix branch April 8, 2022 05:37
@taiki-e taiki-e modified the milestones: v0.2, v0.3 Apr 8, 2022
@taiki-e taiki-e mentioned this pull request Jul 7, 2022
Merged
@taiki-e taiki-e deleted the disable-remap-path-prefix branch July 7, 2022 16:39
@taiki-e taiki-e mentioned this pull request Sep 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.

Src file mapping not working properly with trybuild and proc-macro workspace member
1 participant
@taiki-e