Fix "File name or extension is too long" error when merging profile data on Windows #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
reviewed
Aug 6, 2022
src/main.rs
Outdated
| .filter_map(Result::ok); | ||
| let mut input_files = tempfile::NamedTempFile::new()?; | ||
| for path in profraw_files { | ||
| writeln!(input_files, "{}", path.display())?; |
There was a problem hiding this comment.
Maybe it would be more robust to assume valid UTF-8 here and fail loudly if that does not hold. I fear that Path::display performing a lossy translation of the paths could lead to hard-to-diagnose errors down the road.
|
bors r+ |
|
Build succeeded: |
|
Published in 0.4.14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/PyO3/pyo3/runs/7682300607?check_suite_focus=true
Switched to use
-fto pass input files by a temp file.