-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use llvm-args instead of RUST_TEST_THREADS, %Nm instead of NEXTEST_TEST_THREADS #279
Conversation
Ah, we should also pass -fprofile-update=atomic to clang. Line 278 in 752a20e
|
637b492
to
81a1bd6
Compare
It works and works correctly as far as I tested. But I don't see any time difference. |
As for NEXTEST_TEST_THREADS, I have replaced it with the way described in #258 (comment). I have confirmed that #258 is fixed, but have not yet been able to test whether the original problem is completely fixed. $ cargo llvm-cov nextest
Compiling a v0.1.0 (/Users/taiki/projects/tmp/a)
Finished test [unoptimized + debuginfo] target(s) in 0.14s
Starting 2 tests across 2 binaries
PASS [ 8.015s] a tests::test_8
PASS [ 30.015s] a::functional_tests test_30
------------
Summary [ 30.018s] 2 tests run: 2 passed, 0 skipped |
bf4370f
to
173cadb
Compare
As result, on my real code base, I got such results: Great! The coverage numbers are little different:
but I use https://github.com/BurntSushi/quickcheck that uses random generator, So, I finally can add all crates, not only important ones, in my workspace into coverage calculation for every CI run. |
Could this be merged? From what I can tell, this is good to go, no? |
ac365d9
to
04e192a
Compare
04e192a
to
ee3e3b8
Compare
Published in v0.5.20. Thanks @Dushistov for testing this! |
cargo-llvm-cov no longer sets the
RUST_TEST_THREADS
environment variable and uses llvm-args instead for workaround rust-lang/rust#91092.TODO: skip passing llvm-args on newer nightly that includes rust-lang/rust#111469.
Closes #258
cc @Dushistov