Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in --exclude option #30

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Fix bug in --exclude option #30

merged 1 commit into from
Jun 10, 2021

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Jun 10, 2021

This fixes a bug described in the following comment:

cargo-llvm-cov/src/main.rs

Lines 237 to 239 in 16cd210

// TODO: Currently, there is a problem that excluded crates are
// incorrectly shown in the coverage report if they are path
// dependencies of other crates.

(This PR's approach still incomplete in practice, but it should work in many cases.)

@taiki-e
Copy link
Owner Author

taiki-e commented Jun 10, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 10, 2021

Build succeeded:

@bors bors bot merged commit fe9b37e into main Jun 10, 2021
@bors bors bot deleted the exclude branch June 10, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant