Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not handle .d files as object #317

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Do not handle .d files as object #317

merged 1 commit into from
Sep 26, 2023

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Sep 26, 2023

Workaround for #316. Other extensions may need to be added to the ignore list in the future, but it should work as a workaround for the WSL bug for now.

This also replaces cfg!(windows) with more robust ones.

Fixes #316

cc @robo9k Could you test this? (I don't have WSL environment)

This also replaces cfg!(windows) with more robust ones.
@robo9k
Copy link

robo9k commented Sep 26, 2023

$ cargo +stable install --git https://github.com/taiki-e/cargo-llvm-cov.git --branch object cargo-llvm-cov
    Replaced package `cargo-llvm-cov v0.5.32` with `cargo-llvm-cov v0.5.32 (https://github.com/taiki-e/cargo-llvm-cov.git?branch=object#f40fdb5a)` (executable `cargo-llvm-cov`)

$ cargo +stable llvm-cov --lcov --output-path lcov.info
    Finished report saved to lcov.info

Looks like it's working in WSL with this fix and I'm also seeing coverage in VSCode 🥳

@taiki-e taiki-e merged commit e5c8e41 into main Sep 26, 2023
@taiki-e taiki-e deleted the object branch September 26, 2023 17:20
@taiki-e
Copy link
Owner Author

taiki-e commented Sep 26, 2023

Published in 0.5.33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to load coverage: The file was not recognized as a valid object file - in WSL
2 participants