Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get target and profile from nextest archive #349

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Feb 22, 2024

Better solution for #334 and #348. (FYI @cwfitzgerald @weiznich)

Open the zstd file, parse the nextest metadata, and if that does not work (I assume it is a format that not stable between breaking releases), follow what is passed in the arguments.

This eliminates the need in most cases to pass the flags passed to cargo llvm-cov nextest-archive to cargo llvm-cov nextest --archive-file again.

Before:

cargo llvm-cov nextest-archive --archive-file a.tar.zst --release
cargo llvm-cov nextest --archive-file a.tar.zst --text --fail-under-lines 70 --release

cargo llvm-cov nextest-archive --archive-file a.tar.zst --target "${host}"
cargo llvm-cov nextest --archive-file a.tar.zst --text --fail-under-lines 70 --target "${host}"

After:

cargo llvm-cov nextest-archive --archive-file a.tar.zst --release
cargo llvm-cov nextest --archive-file a.tar.zst --text --fail-under-lines 70

cargo llvm-cov nextest-archive --archive-file a.tar.zst --target "${host}"
cargo llvm-cov nextest --archive-file a.tar.zst --text --fail-under-lines 70

@taiki-e taiki-e added the A-nextest Area: nextest integration https://github.com/nextest-rs/nextest label Feb 22, 2024
@taiki-e taiki-e merged commit 8c737ae into main Feb 22, 2024
18 checks passed
@taiki-e taiki-e deleted the nextest-archive branch February 22, 2024 05:48
@taiki-e
Copy link
Owner Author

taiki-e commented Feb 22, 2024

Published in 0.6.6.

@weiznich
Copy link
Contributor

Thanks for the fast fix ❤️ That's really appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-nextest Area: nextest integration https://github.com/nextest-rs/nextest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants