Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip merging profraw data if profraw files don't exist and a profdata file already exists #360

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

weiznich
Copy link
Contributor

@weiznich weiznich commented Apr 4, 2024

This change allows skipping merging the profraw data if a profdata file already exists. For distributed test runs (like for example nextests partitions) this allows merging the profraw files manually on each runner and only transfer the much smaller profdata file to the final job. There we can just merge the different profdata files manually and place it in the correct location. By allowing tho skip this check we can then use the existing cargo-llvm-cov infrastructure to generate reports.

@taiki-e
Copy link
Owner

taiki-e commented Apr 4, 2024

Thanks for the PR!

For distributed test runs (like for example nextests partitions) this allows merging the profraw files manually on each runner and only transfer the much smaller profdata file to the final job.

This seems to solve #281 (cc @TriplEight)?

src/main.rs Outdated Show resolved Hide resolved
Co-authored-by: Taiki Endo <te316e89@gmail.com>
@taiki-e
Copy link
Owner

taiki-e commented Apr 4, 2024

@weiznich

This change allows skipping merging the profraw data if a profdata file already exists.

Does this describe exactly the behavior you intended? In that case, I think this patch is incorrect. What this patch does is "skip merging profraw files if profraw files don't exist and a profdata file already exists". It should work as is for your use case, but just in case.

@weiznich
Copy link
Contributor Author

weiznich commented Apr 5, 2024

Yes that's correct, I've updated the PR description to make that more clear.

@weiznich weiznich changed the title Skip merging profraw data if the profdata file already exists Skip merging profraw data if profraw files don't exist and a profdata file already exists Apr 5, 2024
@taiki-e taiki-e merged commit 2387e18 into taiki-e:main Apr 5, 2024
18 checks passed
@taiki-e
Copy link
Owner

taiki-e commented Apr 5, 2024

Published in 0.6.9.

@TriplEight
Copy link

@taiki-e let me some time to rebase and re-run my tests again, I'll answer you then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants