Add --mcdc flag, and handle MC/DC fields correctly in LLVM JSON
#383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
force-pushed
the
mcdc
branch
4 times, most recently
from
994d950 to
e9370d2
Compare
|
CI is segfaulting somewhere in the LLVM bindings, probably because mcdc support is broken in the compiler right now because of llvm 19 changes: I had no problem running things locally with a slightly older nightly (presumably pre llvm-19 update). I’m okay with holding off until this is properly fixed in the compiler. |
taiki-e
reviewed
Aug 21, 2024
This adds a new unstable `--mcdc` flag, similar to `--branch`. Apart from that, the LLVM JSON parser also needed changes to recognize the mcdc-related fields, as it would otherwise silently drop those.
|
(rust-lang/rust#126733 has been merged and will be available in the next nightly.) |
taiki-e
approved these changes
Oct 12, 2024
|
Published in 0.6.14. Thanks @Swatinem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new unstable
--mcdcflag, similar to--branch.Apart from that, the LLVM JSON parser also needed changes to recognize the mcdc-related fields, as it would otherwise silently drop those.
Clippy now rightfully complains that
Workspace::newtakes too many boolean parameters, so there surely is some more opportunity for improvement.