Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --failure-mode option #91

Merged
merged 2 commits into from
Sep 19, 2021
Merged

Implement --failure-mode option #91

merged 2 commits into from
Sep 19, 2021

Conversation

smoelius
Copy link
Contributor

Fixes #90.
I modified the existing merge test. I hope that was okay.
I am open to changing anything in this PR, no matter how small.

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Cargo.toml Outdated
@@ -29,6 +29,7 @@ fs-err = "2.5"
glob = "0.3"
home = "0.5"
is_executable = "1"
itertools = "0.10.1"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be used only in tests. Could you move this to dev-dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. (Sorry, silly mistake.)

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 19, 2021

Build succeeded:

@bors bors bot merged commit 4344198 into taiki-e:main Sep 19, 2021
@taiki-e
Copy link
Owner

taiki-e commented Sep 19, 2021

Published in v0.1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-failure-mode option?
2 participants