Add --detach-path-deps #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
detach-path-deps
branch
2 times, most recently
from
335fe32 to
fd947bd
Compare
taiki-e
force-pushed
the
detach-path-deps
branch
7 times, most recently
from
138ce8d to
3728b33
Compare
This was referenced Feb 12, 2022
taiki-e
force-pushed
the
detach-path-deps
branch
2 times, most recently
from
39fab0d to
ebd5dbc
Compare
|
The fix for #1 was complex so I separated it into a separate patch. An older version of this PR containing it is currently in |
taiki-e
force-pushed
the
detach-path-deps
branch
3 times, most recently
from
57e9a50 to
12195f5
Compare
taiki-e
force-pushed
the
detach-path-deps
branch
from
12195f5 to
8ad5d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If path dependencies exist, the above ways may miss the problem when you publish the crate (e.g., tokio-rs/tokio#4376, tokio-rs/tokio#4490)
By using
--detach-path-depsflag, you can run minimal versions check withpathfields removed from dependencies.--detach-path-deps(--detach-path-deps=all) flag removes all1 path fields by default.By using
--detach-path-deps=skip-exactflag, you can skip the removal of path fields in dependencies with exact version requirements ("=<version>"). For example, this is useful for a pair of a proc-macro and a library that export it.Open questions:
--detach-path-deps=alla reasonable default?This also fixes \ #1 (the 3rd commit)EDIT: see #4 (comment)Footnotes
To exactly, when neither version, git, nor path is specified, an error will occur, so we will remove the path field of all of dependencies for which the version or git URL is specified. ↩