Weaken requirements to a number of enum variants #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackbeam
force-pushed
the
singular-enum
branch
from
1ce69df to
b927c0e
Compare
|
Looks good, thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 15, 2019
15: Weaken requirements to a number of enum variants r=taiki-e a=blackbeam
Hi.
This PR is a straightforward fix for the issue where the following snippet of code won't compile with `error: cannot be implemented for enums with less than two variants`:
```rust
#[derive(Read, Write)]
enum Stream {
Some(SomeStream),
#[cfg(features = "other")]
Other(OtherStream),
}
```
Co-authored-by: Anatoly Ikorsky <aikorsky@gmail.com>
Build succeeded
|
|
Published in 0.9.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This PR is a straightforward fix for the issue where the following snippet of code won't compile with
error: cannot be implemented for enums with less than two variants: