Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-rdme to supported tools #265

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Oct 27, 2023

No description provided.

@joshka
Copy link
Contributor Author

joshka commented Oct 27, 2023

The change in 6b8955b uses the release zip files instead of the zst files (which CI seems to choke on)

info: installing cargo-rdme@latest
info: downloading https://github.com/orium/cargo-rdme/releases/download/v1.4.2/cargo-rdme_v1.4.2_x86_64-apple-darwin.tar.zst
info: verifying sha256 checksum for cargo-rdme_v1.4.2_x86_64-apple-darwin.tar.zst
info: cargo-rdme installed at /usr/local/bin/cargo-rdme
+ cargo-rdme rdme --version
/usr/local/bin/cargo-rdme: line 1: syntax error near unexpected token `���V���܂Y�V�Ǖ��'
/usr/local/bin/cargo-rdme: line 1: `(�/��X��������H�@����Xq��Yu1H�Mk�K@�T&���J)���V���܂Y�V�Ǖ��<ᜆ��>����I>����"|��u��SY�e�" ��A1eW�`>�0��?U~����8���&y�Yo���������#gL�ڻ�6f��<�lf��ȍ��V�v�0�Wٕ���V}b���dk�26��iɬ�2�ou��5����P��Y;U����a�{ydA�!f�´!fц��߯�#�	�	q�2EbԮ����o�W����O�WwG�h�!�Z��'[p
�lجe�l�Y+��f�*�_Z����[��r�ٍ���1K�%���x�eW�NA���Jl�ˢ	1��#�
8�Y���WU=ܧR�٨��?E���^�n�!���#�
1�����̺�?	�-	M���L���+�hfď��>����/������I#~D����~����	��������Cb���H���2���_)������$F��2��܏����D��V��+.��A~������<���o����&�{�� @'����`���1��3�uX����;�����0�{�	�ۊ��a�'�Nb��su��՟�z�&��m�ڻ����{7���ݨ
2]!�j\�m+fvo81r�{�p���%n�+�]���cZ��I#����7��T�\�!̦��(��@���+Ir��ΊX�9�"�M�l\�-������}'
+ cargo-rdme rdme --help
/usr/local/bin/cargo-rdme: line 1: syntax error near unexpected token `���V���܂Y�V�Ǖ��'
/usr/local/bin/cargo-rdme: line 1: `(�/��X��������H�@����Xq��Yu1H�Mk�K@�T&���J)���V���܂Y�V�Ǖ��<ᜆ��>����I>����"|��u��SY�e�" ��A1eW�`>�0��?U~����8���&y�Yo���������#gL�ڻ�6f��<�lf��ȍ��V�v�0�Wٕ���V}b���dk�26��iɬ�2�ou��5����P��Y;U����a�{ydA�!f�´!fц��߯�#�	�	q�2EbԮ����o�W����O�WwG�h�!�Z��'[p
�lجe�l�Y+��f�*�_Z����[��r�ٍ���1K�%���x�eW�NA���Jl�ˢ	1��#�
8�Y���WU=ܧR�٨��?E���^�n�!���#�
1�����̺�?	�-	M���L���+�hfď��>����/������I#~D����~����	��������Cb���H���2���_)������$F��2��܏����D��V��+.��A~������<���o����&�{�� @'����`���1��3�uX����;�����0�{�	�ۊ��a�'�Nb��su��՟�z�&��m�ڻ����{7���ݨ
2]!�j\�m+fvo81r�{�p���%n�+�]���cZ��I#����7��T�\�!̦��(��@���+Ir��ΊX�9�"�M�l\�-������}'
Error: Process completed with exit code 2.

@taiki-e
Copy link
Owner

taiki-e commented Oct 27, 2023

zst files

To use tar.zst, you have to add *.tar.zst case to this case block.

@joshka
Copy link
Contributor Author

joshka commented Oct 27, 2023

zst files

To use tar.zst, you have to add *.tar.zst case to this case block.

I noticed that - figured I'd try to avoid it instead, not sure why the bin location was broken in the previous CI run, but figure it's better to just add zstd instead.

@joshka joshka force-pushed the add-cargo-rdme branch 10 times, most recently from 69ddc1c to 2a07b6e Compare October 27, 2023 06:00
main.sh Outdated Show resolved Hide resolved
@joshka joshka force-pushed the add-cargo-rdme branch 5 times, most recently from 740d523 to 8a068f1 Compare October 27, 2023 06:36
@joshka
Copy link
Contributor Author

joshka commented Oct 27, 2023

Whew - got some green now at least :D Still failing a few OSes though.

@joshka joshka force-pushed the add-cargo-rdme branch 2 times, most recently from 959c193 to e7fa3ce Compare October 27, 2023 06:53
@joshka
Copy link
Contributor Author

joshka commented Oct 27, 2023

Removed the zstd code as it was incompatible with macos-11, alpine, almalinux, centos (using bz2 and zip files from cargo-rdme instead). I'm sure there's a way to get that going, but my goal was not to make zstd work for install-action, it was to just get cargo-rdme available as a tool for CI.

Last change was fixing the tidy dictionary for rdme.

@joshka
Copy link
Contributor Author

joshka commented Oct 27, 2023

Finally all the checks are passing on this (I love when CI servers make me feel like the biggest noob :)) I've rebased the PR on main in the last push to make it easy to merge.

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 78f1f74 into taiki-e:main Oct 27, 2023
26 checks passed
@taiki-e
Copy link
Owner

taiki-e commented Oct 27, 2023

Published in 2.21.0.

@joshka joshka deleted the add-cargo-rdme branch October 27, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants