Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-sort #344

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Add cargo-sort #344

merged 1 commit into from
Jan 24, 2024

Conversation

jhpratt
Copy link
Contributor

@jhpratt jhpratt commented Jan 22, 2024

No description provided.

@jhpratt
Copy link
Contributor Author

jhpratt commented Jan 22, 2024

Not sure why alpine is failing, as it appears as though it was installed successfully. CentOS and Ubuntu 18.04 are both failing because glibc is too old, I presume. I'm not sure if there's anything that can be done about this?

@NobodyXu
Copy link
Collaborator

Not sure why alpine is failing, as it appears as though it was installed successfully. CentOS and Ubuntu 18.04 are both failing because glibc is too old, I presume. I'm not sure if there's anything that can be done about this?

How about swithcing to musl for all targets?

That should fix error on ubuntu 18.04 and CentOS, the error on Alpine is probably because glibc cannot be found.

@taiki-e
Copy link
Owner

taiki-e commented Jan 23, 2024

Not sure why alpine is failing, as it appears as though it was installed successfully. CentOS and Ubuntu 18.04 are both failing because glibc is too old, I presume. I'm not sure if there's anything that can be done about this?

If a musl binary is provided, please change to use it. If not, please add the tool name to one of the *_incompat lists here.

# They don't provide prebuilt binaries for musl or old glibc host.
glibc_pre_2_34_incompat=(
xbuild
)
glibc_pre_2_31_incompat=(
"${glibc_pre_2_34_incompat[@]}"
zola
)
glibc_pre_2_27_incompat=(
"${glibc_pre_2_31_incompat[@]}"
cargo-watch
mdbook-linkcheck
protoc
valgrind
wasmtime
)
musl_incompat=(
"${glibc_pre_2_27_incompat[@]}"
)

@jhpratt
Copy link
Contributor Author

jhpratt commented Jan 23, 2024

The binaries included are the only three provided, so I've added an incompatibility as requested. CI is now passing.

@NobodyXu NobodyXu merged commit 1793b9c into taiki-e:main Jan 24, 2024
26 checks passed
@taiki-e
Copy link
Owner

taiki-e commented Jan 24, 2024

Published in 2.26.0. Thanks @jhpratt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants