Add wasm-bindgen

[Ekleog]

Hey! I need to use wasm-bindgen-test-runner in CI, and thought I'd contribute back implementation of it.

Just to say, the wasm-bindgen-cli package actually includes other binaries (wasm-bindgen and wasm2es6js). I'm not a user of these packages and I don't know how useful they'd be in CI, so I didn't focus on them, but… it looks like in order to download multiple packages from a single archive, the user would have to download the archive one time for each binary, and we'd have to maintain the json file once for each binary?

So the main thing I'm unsure of is the naming of the tool. Should I have it be wasm-bindgen-test-runner, as there currently can be a single executable per tool? Or should we first support multiple executables per tool and then name it wasm-bindgen-cli, to match the way it can currently be installed via binstall? (I'll say that I probably won't have time to do the second option)

Also I'll take advantage to ask: I also wanted to integrate sqlx-cli, but AFAICT its releases do not have binaries published. Do I understand correctly that install-action is thus unable to help here?

[Ekleog]

I think this is ready for review! :D There is just the tidy test that is failing, but it is not related to this PR and seems to be due to the way CI works. I tried simply moving main.sh to tools/, but then other things started failing. Not knowing whether that is actually the way you want to go, I just gave up on fixing CI and left this one red :)

[Ekleog]

Ooh I see, thank you for your answers!

I just removed the drive-by addition of the version field, if as you say codegen isn't supposed to work with older rustc versions and version-less manifests are not going away anyway :)

Now CI passed, please let me know if you think there are other changes to make to this PR!

The main question I have is still how to deal with the multiple-binaries-inside-a-single-crate situation: currently it's possible to install things via wasm-bindgen-cli which will proxy through binstall, but AFAICT I can't just add a manifest that'd install multiple binaries, so I can't just name the tool wasm-bindgen-cli :/

[NobodyXu]

LGTM, but I'd let taiki-e to merge this, just in case I missed something.

[taiki-e]

LGTM assuming we merge this with a single binary. However, I would like to do a little evaluation to see how difficult it would be to support multiple binaries before merging. (We have already done something more complicated for protoc but that requires some manually written code.)

[taiki-e]

Ok, I added a commit to support multiple binaries:

info: installing wasm-bindgen@latest
info: downloading https://github.com/rustwasm/wasm-bindgen/releases/download/0.2.91/wasm-bindgen-0.2.91-x86_64-unknown-linux-musl.tar.gz
info: verifying sha256 checksum for wasm-bindgen-0.2.91-x86_64-unknown-linux-musl.tar.gz
info: wasm-bindgen-test-runner installed at /home/runner/.cargo/bin/wasm-bindgen-test-runner
info: wasm-bindgen installed at /home/runner/.cargo/bin/wasm-bindgen
info: wasm2es6js installed at /home/runner/.cargo/bin/wasm2es6js
+ wasm-bindgen --version
wasm-bindgen 0.2.91 (fe8bc949b)

The bin field in base manifest is now:

install-action/tools/codegen/base/wasm-bindgen.json

Lines 7 to 11 in 1779cb5

	"bin": [
	"wasm-bindgen-${version}-${rust_target}/wasm-bindgen-test-runner${exe}",
	"wasm-bindgen-${version}-${rust_target}/wasm-bindgen${exe}",
	"wasm-bindgen-${version}-${rust_target}/wasm2es6js${exe}"
	],

[taiki-e]

Published in 2.28.0. Thanks for the PR!

[Ekleog]

Awesome, thank you for all the improvements you did to support this use case!