-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cargo-zigbuild #508
Add cargo-zigbuild #508
Conversation
80ab528
to
4d4d994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would also need to pip install ziglang
before cargo-zigbuild
is actually usable.
well the assumption is that https://github.com/goto-bus-stop/setup-zig or similar has been also run, either before or after. |
If I am the user, I would assume it has everything installed for cargo-zigbuild to be used. You can special case cargo-zigbuild by doing a |
My understanding of this action is that it does not do extra installs that might be required to make a tool work. It is up to the user of this action to install dependencies that are missing, and that way they can choose the version they want of those dependencies. I would support adding an extra tool called "ziglang", which would be a special case also like "valgrind". We could support installing different versions from https://pypi.org/project/ziglang/#history - that looks like a reasonable approach, but Python wheels are a messy format for this given that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense, having a special support for ziglang along with cargo-zigbuild
Thanks @NobodyXu . |
https://github.com/rust-cross/cargo-zigbuild