Add a dummy lifetime to Wrapper #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we know that `Self` doesn't implement `Unpin` and `Self` doesn't contain any generics or lifetimes, we get an error `E0277`. To avoid this, add a dummy lifetime to the `Wrapper`. This allows `Wrapper<Self>` to always compile regardless of whether `Self` implements `UnsafeUnpin`. As the `Wrapper` implements `UnsafeUnpin` regardless of a lifetime, this should not change the actual bounds of the `Unpin` implementation.
This was referenced Sep 25, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 25, 2019
107: Add a dummy lifetime to Wrapper r=taiki-e a=taiki-e If we know that `Self` doesn't implement `Unpin` and `Self` doesn't contain any generics or lifetimes, we get an error `E0277`. To avoid this, add a dummy lifetime to the `Wrapper`. This allows `Wrapper<Self>` to always compile regardless of whether `Self` implements `UnsafeUnpin`. As the `Wrapper` implements `UnsafeUnpin` regardless of a lifetime, this should not change the actual bounds of the `Unpin` implementation. This allows workaround of #102 that "using `pin_project(UnsafeUnpin)` and not providing a manual `UnsafeUnpin` implementation" to work. Closes #102 cc @Aaron1011 @ogoffart Co-authored-by: Taiki Endo <te316e89@gmail.com>
Build succeeded
|
Merged
bors bot
added a commit
that referenced
this pull request
Sep 25, 2019
109: Release 0.4.0 r=taiki-e a=taiki-e cc #21 ### Changes since the latest 0.3 release: * **Pin projection has become a safe operation.** In the absence of other unsafe code that you write, it is impossible to cause undefined behavior. (#18) * `#[unsafe_project]` attribute has been replaced with `#[pin_project]` attribute. (#18, #33) * The `Unpin` argument has been removed - an `Unpin` impl is now generated by default. (#18) * Drop impls must be specified with `#[pinned_drop]` instead of via a normal `Drop` impl. (#18, #33, #86) * `Unpin` impls must be specified with an impl of `UnsafeUnpin`, instead of implementing the normal `Unpin` trait. (#18) * `#[pin_project]` attribute now determines the visibility of the projection type/method is based on the original type. (#96) * `#[pin_project]` can now be used for public type with private field types. (#53) * `#[pin_project]` can now interoperate with `#[cfg()]`. (#77) * Added `project_ref` method to `#[pin_project]` types. (#93) * Added `#[project_ref]` attribute. (#93) * Removed "project_attr" feature and always enable `#[project]` attribute. (#94) * `#[project]` attribute can now be used for `impl` blocks. (#46) * `#[project]` attribute can now be used for `use` statements. (#85) * `#[project]` attribute now supports `match` expressions at the position of the initializer expression of `let` expressions. (#51) ### Changes since the 0.4.0-beta.1 release: * Fixed an issue that caused an error when using `#[pin_project(UnsafeUnpin)]` and not providing a manual `UnsafeUnpin` implementation on a type with no generics or lifetime. (#107) Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we know that
Selfdoesn't implementUnpinandSelfdoesn't contain anygenerics or lifetimes, we get an error
E0277.To avoid this, add a dummy lifetime to the
Wrapper. This allowsWrapper<Self>to always compile regardless of whetherSelfimplements
UnsafeUnpin.As the
WrapperimplementsUnsafeUnpinregardless of a lifetime, thisshould not change the actual bounds of the
Unpinimplementation.This allows workaround of #102 that "using
pin_project(UnsafeUnpin)and not providing a manual
UnsafeUnpinimplementation" to work.Closes #102
cc @Aaron1011 @ogoffart