Fix compile error with dyn types
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 21, 2019
158: Fix compile error with `dyn` types r=taiki-e a=oxalica
Add parentheses around original types in generated code.
Currently, it will cause a compile error when field type is like `dyn Trait1 + Trait2`.
```rust
use pin_project::pin_project;
#[pin_project]
struct Struct {
a: i32,
#[pin]
f: dyn std::fmt::Debug + Send,
}
```
will result in,
```
error: ambiguous `+` in a type
--> src/main.rs:6:8
|
6 | f: dyn std::fmt::Debug + Send,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use parentheses to disambiguate: `(dyn std::fmt::Debug + Send)`
error: proc-macro derive produced unparseable tokens
--> src/main.rs:2:1
|
2 | #[pin_project]
| ^^^^^^^^^^^^^^
```
Co-authored-by: oxalica <oxalicc@pm.me>
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Oct 21, 2019
158: Fix compile error with `dyn` types r=taiki-e a=oxalica
Add parentheses around original types in generated code.
Currently, it will cause a compile error when field type is like `dyn Trait1 + Trait2`.
```rust
use pin_project::pin_project;
#[pin_project]
struct Struct {
a: i32,
#[pin]
f: dyn std::fmt::Debug + Send,
}
```
will result in,
```
error: ambiguous `+` in a type
--> src/main.rs:6:8
|
6 | f: dyn std::fmt::Debug + Send,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use parentheses to disambiguate: `(dyn std::fmt::Debug + Send)`
error: proc-macro derive produced unparseable tokens
--> src/main.rs:2:1
|
2 | #[pin_project]
| ^^^^^^^^^^^^^^
```
Co-authored-by: oxalica <oxalicc@pm.me>
Build succeeded
|
|
Published in 0.4.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parentheses around original types in generated code.
Currently, it will cause a compile error when field type is like
dyn Trait1 + Trait2.will result in,