Hide all generated items except for projected types from calling code #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
underscore-const-names
branch
from
21b6b10
to
add5ca5
Compare
taiki-e
added
S-blocked
taiki-e
force-pushed
the
underscore-const-names
branch
2 times, most recently
from
9bf87d1
to
c6cd9a2
Compare
taiki-e
changed the title
Keep support for 1.33, remove |
This comment has been minimized.
This comment has been minimized.
bors bot
added a commit
that referenced
this pull request
Apr 19, 2020
192: Hide all items except for projected types from calling code r=taiki-e a=taiki-e Generate all items except for projected types inside a `const` scope. This makes it impossible for user code to refer to these types. This removes redundant prefix/postfix based on the original type from many generate types. This also remove the `pin_project_show_unpin_struct` flag. Co-authored-by: Taiki Endo <te316e89@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
taiki-e
force-pushed
the
underscore-const-names
branch
from
c6cd9a2
to
9eba3fe
Compare
taiki-e
changed the title
taiki-e
force-pushed
the
underscore-const-names
branch
from
9eba3fe
to
2577f02
Compare
taiki-e
force-pushed
the
underscore-const-names
branch
from
2577f02
to
fd1924d
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 7, 2020
211: Hide generated items from --document-private-items r=taiki-e a=taiki-e All of the generated items are private items, but it can be displayed in the document by using the `--document-private-items` flag. Naming will be allowed by #202, so it would probably be preferable to only display it in the document if the user did a naming. cc #124 #202 Related: #192 Co-authored-by: Taiki Endo <te316e89@gmail.com>
taiki-e
removed
the
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate all items except for projected types inside a
constscope. This makes it impossible for user code to refer to these types. This removes redundant prefix/postfix based on the original type from many generate types. This also remove thepin_project_show_unpin_structflag.