Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent user call __drop_inner #223

Merged
merged 1 commit into from
May 11, 2020
Merged

Prevent user call __drop_inner #223

merged 1 commit into from
May 11, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented May 11, 2020 •
edited
Loading

This is an internal function, and the user should not be able to call this. Ideally, we should use a def-site span, but we can't do that, so add a dummy __drop_inner function at the beginning of __drop_inner function.

playground

@taiki-e

This comment has been minimized.

Sign in to view
bors bot added a commit that referenced this pull request May 11, 2020
@bors @taiki-e
Merge #223
ed58de8 
223: Prevent user call `__drop_inner` r=taiki-e a=taiki-e



Co-authored-by: Taiki Endo <te316e89@gmail.com>
@bors

This comment has been minimized.

Sign in to view
@taiki-e taiki-e added A-drop Area: #[pinned_drop] and Drop relnotes labels May 11, 2020
@taiki-e
Copy link
Owner Author

taiki-e commented May 11, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented May 11, 2020

Build succeeded:

@bors bors bot merged commit 20e31f9 into master May 11, 2020
@bors bors bot deleted the drop-inner branch May 11, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-drop Area: #[pinned_drop] and Drop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taiki-e