Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.37 #292

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Bump MSRV to 1.37 #292

merged 1 commit into from
Oct 5, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Oct 5, 2020

Bumps MSRV to 1.37 because underscore_const_names requires 1.37. This allows removing the build script.

It's been more than a year since 1.37 was released, and most of the users of this crate depend on futures_api that requires 1.36 and async_await that requires 1.39. so bumping MSRV to 1.37 is probably no problem.
Also, given that pin-project-lite's MSRV is 1.37 and the possibility of switching, most futures-related utilities require at least 1.37.

cc #264
Refs: #219

@taiki-e taiki-e added this to the v1.0 milestone Oct 5, 2020
@taiki-e
Copy link
Owner Author

taiki-e commented Oct 5, 2020

As far as I know, futures/futures-util/futures-test with no-default-features are the only futures-related utilities that have been tested to compatibility with 1.36 and depend on pin-project.
However, this should be fine as that is undocumented and there is a possibility of switching to pin-project-lite. (also probably many users have the default or async-await feature enabled.)

underscore_const_names requires 1.37
@taiki-e
Copy link
Owner Author

taiki-e commented Oct 5, 2020

bors r+

See also #264 (comment)

@bors
Copy link
Contributor

bors bot commented Oct 5, 2020

Build succeeded:

@bors bors bot merged commit 04266f7 into master Oct 5, 2020
@bors bors bot deleted the msrv branch October 5, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant