Skip to content

Commit

Permalink
Fix warning with -Z minimal-versions
Browse files Browse the repository at this point in the history
```
error: non-local `impl` definition, they should be avoided as they go against expectation
   --> src/gen/ast_struct.rs:9:10
    |
  9 | #[derive(Serialize, Deserialize)]
    |          ^^^^^^^^^
    |
    = help: move this `impl` block outside the of the current constant `_IMPL_SERIALIZE_FOR_Abi`
    = note: an `impl` definition is non-local if it is nested inside an item and neither the type nor the trait are at the same nesting level as the `impl` block
    = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
    = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <rust-lang/rust#120363>
    = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive`
    = note: `-D non-local-definitions` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(non_local_definitions)]`
    = note: this error originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info)
```
  • Loading branch information
taiki-e committed Feb 26, 2024
1 parent 09f6ede commit 747c277
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ json = ["serde_json"]
# Note: proc-macro2, serde, serde_json, and syn are public dependencies.
[dependencies]
proc-macro2 = { version = "1.0.60", default-features = false }
serde = "1.0.103"
serde_derive = "1.0.103"
serde = "1.0.165"
serde_derive = "1.0.165"
syn = { version = "2", default-features = false, features = ["full"] }

serde_json = { version = "1", optional = true }
Expand Down

0 comments on commit 747c277

Please sign in to comment.