Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of the Scroll’s LogUp Lookup Protocol Into the PSE’s Halo2 Version 0.3.0 #18

Open
wants to merge 6 commits into
base: pse/0.3.0
Choose a base branch
from

Update prover.rs

540427f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Integration of the Scroll’s LogUp Lookup Protocol Into the PSE’s Halo2 Version 0.3.0 #18

Update prover.rs
540427f
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy (beta) failed Mar 3, 2024 in 0s

Clippy (beta)

1 error, 14 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 14
Note 0
Help 0

Versions

  • rustc 1.67.0 (fc594f156 2023-01-24)
  • cargo 1.67.0 (8ecd4f20a 2023-01-10)
  • clippy 0.1.67 (fc594f1 2023-01-24)

Annotations

Check warning on line 672 in halo2_proofs/src/dev/failure.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_proofs/src/dev/failure.rs:672:17
    |
672 |                 eprintln!("    |   x{} = {}", i, value);
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
672 -                 eprintln!("    |   x{} = {}", i, value);
672 +                 eprintln!("    |   x{i} = {value}");
    |

Check warning on line 650 in halo2_proofs/src/dev/failure.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_proofs/src/dev/failure.rs:650:32
    |
650 |                     .or_insert(format!("x{}", i));
    |                                ^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
help: change this to
    |
650 -                     .or_insert(format!("x{}", i));
650 +                     .or_insert(format!("x{i}"));
    |

Check warning on line 92 in halo2_proofs/src/plonk/mv_lookup/verifier.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this function has too many arguments (11/7) 

warning: this function has too many arguments (11/7)
  --> halo2_proofs/src/plonk/mv_lookup/verifier.rs:80:5
   |
80 | /     pub(in crate::plonk) fn expressions<'a>(
81 | |         &'a self,
82 | |         l_0: C::Scalar,
83 | |         l_last: C::Scalar,
...  |
91 | |         challenges: &[C::Scalar],
92 | |     ) -> impl Iterator<Item = C::Scalar> + 'a {
   | |_____________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 283 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`) 

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:283:31
    |
283 |             let num_chunks = (active_size as usize + chunk - 1) / chunk;
    |                               ^^^^^^^^^^^^^^^^^^^^ help: try: `active_size`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 277 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`) 

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:277:33
    |
277 |                 let mut chunk = (active_size as usize) / num_threads;
    |                                 ^^^^^^^^^^^^^^^^^^^^^^ help: try: `active_size`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 132 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`u64` -> `u64`) 

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:132:35
    |
132 |                 .map(|mi| F::from(mi.load(Ordering::Relaxed) as u64))
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `mi.load(Ordering::Relaxed)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`

Check warning on line 64 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this function has too many arguments (11/7) 

warning: this function has too many arguments (11/7)
  --> halo2_proofs/src/plonk/mv_lookup/prover.rs:44:5
   |
44 | /     pub(in crate::plonk) fn prepare<
45 | |         'a,
46 | |         'params: 'a,
47 | |         C,
...  |
63 | |         transcript: &mut T,
64 | |     ) -> Result<Prepared<C>, Error>
   | |___________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `-W clippy::too-many-arguments` implied by `-W clippy::all`

Check failure on line 41 in halo2_proofs/benches/lookups.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

not all trait items implemented, missing: `Params` 

error[E0046]: not all trait items implemented, missing: `Params`
  --> halo2_proofs/benches/lookups.rs:41:5
   |
41 |     impl<F: PrimeField> Circuit<F> for MyCircuit<F> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `Params` in implementation
   |
   = help: implement the missing item: `type Params = Type;`

Check warning on line 672 in halo2_proofs/src/dev/failure.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_proofs/src/dev/failure.rs:672:17
    |
672 |                 eprintln!("    |   x{} = {}", i, value);
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
672 -                 eprintln!("    |   x{} = {}", i, value);
672 +                 eprintln!("    |   x{i} = {value}");
    |

Check warning on line 650 in halo2_proofs/src/dev/failure.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_proofs/src/dev/failure.rs:650:32
    |
650 |                     .or_insert(format!("x{}", i));
    |                                ^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
help: change this to
    |
650 -                     .or_insert(format!("x{}", i));
650 +                     .or_insert(format!("x{i}"));
    |

Check warning on line 92 in halo2_proofs/src/plonk/mv_lookup/verifier.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this function has too many arguments (11/7) 

warning: this function has too many arguments (11/7)
  --> halo2_proofs/src/plonk/mv_lookup/verifier.rs:80:5
   |
80 | /     pub(in crate::plonk) fn expressions<'a>(
81 | |         &'a self,
82 | |         l_0: C::Scalar,
83 | |         l_last: C::Scalar,
...  |
91 | |         challenges: &[C::Scalar],
92 | |     ) -> impl Iterator<Item = C::Scalar> + 'a {
   | |_____________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 283 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`) 

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:283:31
    |
283 |             let num_chunks = (active_size as usize + chunk - 1) / chunk;
    |                               ^^^^^^^^^^^^^^^^^^^^ help: try: `active_size`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 277 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`) 

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:277:33
    |
277 |                 let mut chunk = (active_size as usize) / num_threads;
    |                                 ^^^^^^^^^^^^^^^^^^^^^^ help: try: `active_size`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 132 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`u64` -> `u64`) 

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:132:35
    |
132 |                 .map(|mi| F::from(mi.load(Ordering::Relaxed) as u64))
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `mi.load(Ordering::Relaxed)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`

Check warning on line 64 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this function has too many arguments (11/7) 

warning: this function has too many arguments (11/7)
  --> halo2_proofs/src/plonk/mv_lookup/prover.rs:44:5
   |
44 | /     pub(in crate::plonk) fn prepare<
45 | |         'a,
46 | |         'params: 'a,
47 | |         C,
...  |
63 | |         transcript: &mut T,
64 | |     ) -> Result<Prepared<C>, Error>
   | |___________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `-W clippy::too-many-arguments` implied by `-W clippy::all`
View more details on GitHub Actions