fix(lib): temporarily disable kzg check in sgx/sp1 provers #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the addr management has different requirement than risc0. |
quangtuyen88
pushed a commit
to quangtuyen88/raiko
that referenced
this pull request
May 6, 2024
update path for chmod default.json Added step install nodejs feat(raiko): enable kzg blob check (taikoxyz#148) * feat(raiko): enable kzg blob check * update build script * update ci * fix ci * keep fixing ci * keep fixing ci - sgx docker build * fix ci risc0 * update ci env feat(raiko): generalized build pipeline for ZkVMs guests (taikoxyz#133) * init + some taiko_util -> util * pipeline * example * r0 bins & tests done * exmple-sp1 done * gen proof with unittests * test harness for sp1 doen + split the builder and driver * make example a workspace * change dest param * harness upgrade * image id compute * cleanup * pipeline api change * r0 switch builder-driver * r0 switch builder-driver * sp1 prover -> driver rename * sp1 builder * cargo check passed * name changes * commented out sp1 & ris0 flags in irrelavent setup * fixes + makefile * update * clean up * update CI r0 * update sp1 * add builder to workspace * sp1 CI permission denied * add example test in guest + clippy * add test to CI * fmt & fix CI bug * test with --release + toolchain * fix * fix docker * add CC support for c-kzg * trait Pipeline impl in specific builder * fix ci * download & verify riscv-gcc-prebuilt * Update pipeline/src/lib.rs * update script * Updated readme + fix local building * cargo: -> cargo:: --------- Co-authored-by: Brechtpd <Brechtp.devos@gmail.com> fix(lib): temporarily disable kzg check in sgx/sp1 provers (taikoxyz#157) * temporarily disable kzg check in sgx/sp1 provers * fix typo fast on-chain register + change path before clone repo
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some problems in SGX and SP1 while proving with the kzg check, so I temporarily disabled them in those provers. Well actually it is currently always disabled because sgx is enabled in the workspace so it will always compile the lib with that feature on, so using features not exactly the best way to do these kind of prover specific things unfortunately.
In SGX (direct mode):
In SP1: