Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow and fix typos #182

Closed
wants to merge 1 commit into from
Closed

Add workflow and fix typos #182

wants to merge 1 commit into from

Conversation

miles-six
Copy link

I fix some typos and want to add workflow for codespell check to eliminate typos in the future.

I have added a relatively simple filtering file to exclude certain words.

If you find it meaningful, you can modify the filtering conditions according to your needs.

The code quality is exceptionally high, so sincerely hope my PR can help make this repository more standardized.

@davidtaikocha
Copy link
Member

Since this repo is a fork of go-ethereum, I think the better way to fix those typos is to open a PR in go-ethereum repo, and after its merged, we will merge the changes back.

@miles-six
Copy link
Author

@davidtaikocha thank you sir, as you said,I fix these typos in go-ethereum repo , and be merged:ethereum#29288 (comment)

@davidtaikocha
Copy link
Member

Great, we will include this when we merge back the upstream changes next time :)

@miles-six
Copy link
Author

@davidtaikocha btw sir, the last question :Will Taiko's Poap of 2024 distribute in the future?

@davidtaikocha
Copy link
Member

For your go-ethereum PR, I think no, it's basically a PR in another different project. Maybe u can try to make more contributions to this repo: https://github.com/taikoxyz/taiko-mono

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants