feat(beacon): introduce soft blocks #342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mask-pp
reviewed
Nov 5, 2024
Co-authored-by: maskpp <maskpp266@gmail.com>
davidtaikocha
commented
Nov 5, 2024
| @@ -33,3 +33,6 @@ var HeklaGenesisAllocJSON []byte | |||
|
|
|||
| //go:embed mainnet.json | |||
| var MainnetGenesisAllocJSON []byte | |||
|
|
|||
| //go:embed preconf_devnet.json | |||
There was a problem hiding this comment.
@cyberhorsey not sure which taiko-mono branch I should use for generating the genesis JSON, so I copied the internal devnet genesis JSON here temporarily
mask-pp
reviewed
Nov 5, 2024
mask-pp
reviewed
Nov 5, 2024
mask-pp
reviewed
Nov 5, 2024
mask-pp
reviewed
Nov 5, 2024
Co-authored-by: maskpp <maskpp266@gmail.com>
mask-pp
reviewed
Nov 6, 2024
Co-authored-by: maskpp <maskpp266@gmail.com>
mask-pp
reviewed
Nov 6, 2024
mask-pp
approved these changes
Nov 6, 2024
…to make `IsSoftblock` return `false`
mask-pp
reviewed
Nov 13, 2024
* use debug log level to avoid logging too many logs when frequently soft block reorg. * use debug log level to avoid logging too many logs when frequently soft block reorg. * feat: check --taiko flag --------- Co-authored-by: David <david@taiko.xyz>
* remove the reverted l1Origins * feat: add more comments --------- Co-authored-by: David <david@taiko.xyz>
johntaiko
reviewed
Dec 26, 2024
| @@ -52,16 +69,40 @@ func WriteL1Origin(db ethdb.KeyValueWriter, blockID *big.Int, l1Origin *L1Origin | |||
| } | |||
| } | |||
|
|
|||
| // ReadL1Origin retrieves the given L2 block's L1Origin from database. | |||
| // DeleteL1Origin removes the L1Origin. | |||
| func DeleteL1Origin(db ethdb.KeyValueWriter, blockID *big.Int) { | |||
There was a problem hiding this comment.
What happened when delete the head l1origin?
There was a problem hiding this comment.
We inserted the newest l1origin id by WriteHeadL1Origin, but it will reach the null pointer after deleting the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.