Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(protocol): forge fmt --check in protocol workflow #15757

Merged
merged 5 commits into from
Feb 13, 2024
Merged

ci(protocol): forge fmt --check in protocol workflow #15757

merged 5 commits into from
Feb 13, 2024

Conversation

dionysuzx
Copy link
Collaborator

@dionysuzx dionysuzx commented Feb 12, 2024

how things work

  • lefthook should handle this for devs, but if devs disable lefthook with LEFTHOOK=0 (which is fine!), then this lint job will error out

@dionysuzx dionysuzx requested a review from dantaik February 12, 2024 23:19
@dionysuzx dionysuzx enabled auto-merge (squash) February 12, 2024 23:19
@dionysuzx dionysuzx requested a review from adaki2004 February 12, 2024 23:19
@dantaik
Copy link
Contributor

dantaik commented Feb 13, 2024

@d1onys1us Not sure why this PR cannot be merged.

auto-merge was automatically disabled February 13, 2024 14:59

Base branch was modified

@dionysuzx dionysuzx merged commit bb02a15 into main Feb 13, 2024
5 of 12 checks passed
@dionysuzx dionysuzx deleted the add-lint branch February 13, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants